coot/cardano ping #3204
Merged
coot/cardano ping #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Jun 10, 2021
coot
commented
- Add support for V7 keepalive
- cardano-ping: adhare to keep alive protocol
karknu
requested changes
Jun 10, 2021
network-mux/demo/cardano-ping.hs
Outdated
Comment on lines
225
to
229
| keepAliveDone :: ByteString | ||
| keepAliveDone = | ||
| CBOR.toLazyByteString $ | ||
| CBOR.encodeListLen 1 | ||
| <> CBOR.encodeWord 2 |
There was a problem hiding this comment.
You should cover the pre v7 version of the protocol too.
There was a problem hiding this comment.
Note the shortcoming of the approach of integration of version and version data: we need to pattern match on the version number: when we will add v8 for node-to-node the cardano-ping will break if one forgets to update the encoder.
There was a problem hiding this comment.
I pushed one more commit to fix this.
* send terminating message (`MsgDone`), * add 5 sec protocol idle timeout, this allows for a clean connection termination.
Instead of pattern matching on a version use the `Ord` instance, though it is a bit artificial to use `NodeToNodeVersionV7 minBound minBound`.
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.