-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mempool tracer without bang patterns #3244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice PR description! LGTM.
(Edit: It looks like this worked; the Nix build is now green.) It looks like you won the lottery with that Nix failure 👏👏👏 I have opened #3250 to look into it. I anticipate that if we ran this PR's Hydra evals again, it wouldn't happen; I think you just got "lucky". So I'm going to try to force Hydra to do that now. I restarted https://hydra.iohk.io/build/6835752, which had looked like this: Your latest was https://hydra.iohk.io/build/6836123, which used a cached failure from the above. I figure Restarting that one would just use the cached failure again. So I think I restart 6835752 and then once it finishes restart 6836123 and then we'll be green 🤞 |
Yes, please merge |
@jutaro Would you rebase it? I expect that |
e4b8417
to
4009666
Compare
I have done the rebasing |
bors r+ |
3244: Mempool tracer without bang patterns r=nfrisby a=jutaro For new tracing it is advisable/necessary to remove the strictness annotations of the tracer type. 1. These objects are guaranteed to live only very short (with the new tracing framework). 2. Their is a great probability, that these messages will be filtered out, in which case laziness is better. 3. This is of all the dozens of tracer types the only one with such strictness annotations. 4. The new tracing infrastructure works prototype based. Since it is difficult to construct these objects, we use 'undefined' to make it work, which is not possible with these strictness annotations. Co-authored-by: Yupanqui <jnf@arcor.de>
Build failed: |
bors r+ |
Build succeeded: |
For new tracing it is advisable/necessary to remove the strictness annotations of the tracer type.