Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose srnMaxTxCapacityOverride allowing Node to modify MaxTxCapacityOverride #3246

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Expose srnMaxTxCapacityOverride allowing Node to modify MaxTxCapacityOverride #3246

merged 2 commits into from
Jul 7, 2021

Conversation

EncodePanda
Copy link
Contributor

Fixes #3235

@EncodePanda
Expose srnMaxTxCapacityOverride allowing Node to modify MaxTxCapacity…
365caa2 
…Override
@EncodePanda
Modify the Overrides instances to represent modification function Mea…
54516bb 
…sure blk -> Measure blk

After this change, the Node operator will NOT have to override
MaxTxCapacityOverride with a *specific* value, but they will have an
ability to modify existing limit defined by ledger
@EncodePanda EncodePanda requested a review from nfrisby July 6, 2021 13:23
nfrisby
nfrisby approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@nfrisby nfrisby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a nice PR, so direct :) Functions are so neat! Nice job.

I had one suggestion. Let me know what you think. I think it would simplify the types on both our end and on the cardano-node end, but it might be less future-proof.

ouroboros-consensus/src/Ouroboros/Consensus/Block/Forging.hs Show resolved Hide resolved
@EncodePanda
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 7, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2a8fb97 into master Jul 7, 2021
@iohk-bors iohk-bors bot deleted the EncodePanda/3235-max-override-to-std-args branch July 7, 2021 11:32
coot pushed a commit that referenced this pull request May 16, 2022
@iohk-bors @EncodePanda
Merge #3246
e221354 
3246: Expose srnMaxTxCapacityOverride allowing Node to modify MaxTxCapacityOverride r=EncodePanda a=EncodePanda

Fixes #3235

Co-authored-by: EncodePanda <paul.szulc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrisby nfrisby nfrisby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider moving maxTxCapacityOverride to StdRunNodeArgs
2 participants
@EncodePanda @nfrisby