Bolt12/p2p master attenuation #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
3895e0a
to
ffe1561
Compare
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
ffe1561
to
5ceb375
Compare
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
4 times, most recently
from
860f413
to
910b07d
Compare
|
Could you rebase the branch so that |
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
910b07d
to
15f95a5
Compare
coot
requested changes
Sep 6, 2021
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/src/Ouroboros/Network/ConnectionManager/Core.hs
Show resolved
Hide resolved
ouroboros-network-framework/src/Ouroboros/Network/ConnectionManager/Core.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/src/Ouroboros/Network/ConnectionManager/Core.hs
Outdated
Show resolved
Hide resolved
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
15f95a5
to
2a62a5f
Compare
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
2a62a5f
to
8d575a3
Compare
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
2 times, most recently
from
7144768
to
d0a3f8b
Compare
This was
linked to
issues
Sep 13, 2021
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
2 times, most recently
from
3b8d701
to
b5f129f
Compare
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
c6bef14
to
8cbe8ed
Compare
coot
reviewed
Oct 7, 2021
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/src/Ouroboros/Network/ConnectionManager/Types.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/src/Ouroboros/Network/ConnectionManager/Core.hs
Show resolved
Hide resolved
When requestOutboundConnection is run we have two calls which needs to take care of resources * connect * connection handler thread This patch avoids having resource cleanups for both calls to overlap.
Add corner case transitions to verifyAbstractTrans connection mngr: refactor - Fixes cleanup function TerminatingSt case - Adds and logs TrUnexpectedlyMissingConnectionState Fixes DColdNoop reflexive transition tracing Add TODO to Snocket.hs
The issue was noTimeoutHandshake was being used and there was a thread hanging forever waiting on timeout. Refactor handshakeTimeLimits to top-level: - This allows to decide when to pass timeLimitsHandhsake or noTimeLimitsHandshake, depending on the type of test we're running Extended Server2 with Shutdown action Make connectionLoop resilient so that it can't die
When closing a socket, it does not throw timeout exceptions. If the remote host does not reply, the connection will be evenautlly closed by the OS.
This patch providess UnversionedProtocol which allows to negotiate 'DataFlow'.
When connection is negotiated, it can fail. Pattern match on the current state to verify that it's not 'TerminatedState'.
Since we start using non-trivial attenuation, we can expect IO / multiplexer errors. They should not terminate a simulation.
This is not perfect, so we also remove an assertion from connection-manager. This assertion is benign and also hit rarely (once per 100_000 simulations).
Just redefine the 'debugTracer' term.
caused by a race with withConnectionManager. So ConnectionManager simulation had PopScheduleOutboundError and leaked connections problems. Both problems sources was due to race conditions caused by a wrong assumption that the connVar could be reused if in the Terminating or TerminatedState. We also log TerminatingSt->TerminatedSt in the right place Authors: Marcin Szamotulski
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
8cbe8ed
to
d312b0a
Compare
Be careful when overwriting the state.
The resource handler for `bracketOnError` must be uninterruptible.
This simulation is not designed to handle errors.
These identity transitions are harmless, triggered by hot miniprotocol termination. Rebase fixs
bolt12
force-pushed
the
bolt12/p2p-master-attenuation
branch
from
d312b0a
to
483b2f3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Attenuation to tests and fixes a couple of bugs found in the way.