Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block size to CompletedBlockFetch trace event #3333

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Add block size to CompletedBlockFetch trace event #3333

merged 1 commit into from
Sep 13, 2021

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Sep 9, 2021

Block size has an impact on block delay, which is already traced in this
event. It should be tracked here.

@karknu
Add block size to CompletedBlockFetch trace event
a67352d 
Block size has an impact on block delay, which is already traced in this
event. It should be tracked here.
@karknu karknu requested a review from coot as a code owner September 9, 2021 08:41
bolt12
bolt12 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coot
coot approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karknu
Copy link
Contributor Author

karknu commented Sep 13, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 13, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 3be7ec2 into master Sep 13, 2021
@iohk-bors iohk-bors bot deleted the karknu/block_size branch September 13, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

@coot coot coot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karknu @coot @bolt12