Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce sleeping at least acceptedConnectionsDelay at hard limit #3335

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Sep 10, 2021

Previous logic was switched which could cause the accept thread to sleep
too long.

Thanks to @gufmar for helping with tracking down this issue.

@karknu karknu marked this pull request as ready for review September 10, 2021 11:32
@karknu karknu requested a review from coot as a code owner September 10, 2021 11:32
Previous logic was switched which could cause the accept thread to sleep
too long.
Emit a trace event when we're below the hard limit and redy to accept
new connetions.
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karknu
Copy link
Contributor Author

karknu commented Sep 14, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants