[CAD-3383] Bring db analyser back to life #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrisby
reviewed
Sep 13, 2021
EncodePanda
force-pushed
the
EncodePanda/CAD-3383/bring-db-analyzer-back-to-life
branch
2 times, most recently
from
92e5375
to
f88a26d
Compare
|
@nfrisby I've went through the comments, I've applied two of your suggestions, for the other two I've left my comments. Please have a look . |
|
@dnadales @jasagredo @nfrisby second look? :) |
dnadales
reviewed
Sep 16, 2021
| {-# LANGUAGE TypeFamilies #-} | ||
|
|
||
| {-# OPTIONS_GHC -Wno-orphans #-} | ||
| module Block.Alonzo ( |
There was a problem hiding this comment.
Would it make sense to refer to IntersectMBO/cardano-ledger#2452 in the comments and explain that this module was copied from the node, why it was copied, and that it'll be removed from consensus once 2452 is solved?
dnadales
approved these changes
Sep 16, 2021
This instances was copied from node. But it should really live in ledger spec. Same as ShelleyGenesis does. This should be addressed in the near future.
Once we have AlonzoGenesis FromJSON, providing it to mkCardanoProtocolInfo is just a matter of reading the configuration file provided by the user
To keep code consistent with previous eras
EncodePanda
force-pushed
the
EncodePanda/CAD-3383/bring-db-analyzer-back-to-life
branch
from
be6221c
to
bec44a4
Compare
|
@dnadales it works on Alonzo chain, checked [x] |
|
bors merge |
|
Build succeeded: |
iohk-bors
bot
deleted the
EncodePanda/CAD-3383/bring-db-analyzer-back-to-life
branch
nfrisby
reviewed
Sep 17, 2021
| @@ -114,15 +113,15 @@ mkCardanoProtocolInfo genesisByron signatureThreshold genesisShelley genesisAlon | |||
| , shelleyBasedLeaderCredentials = [] | |||
| } | |||
| ProtocolParamsShelley { | |||
| shelleyProtVer = ProtVer 2 0 | |||
| shelleyProtVer = ProtVer 3 0 | |||
There was a problem hiding this comment.
Nice job debugging these 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FromJSON instance to AlonzoGenesis
This instances was copied from node. But it should really live in
ledger spec. Same as ShelleyGenesis does. This should be addressed in
the near future. Issue was created Move AlonzoGenesis From/ToJSON instances from cardano-node to cardano-ledger-specs cardano-ledger#2452
Bring db-analyser back to life
Once we have AlonzoGenesis FromJSON, providing it to
mkCardanoProtocolInfo is just a matter of reading the configuration
file provided by the user
Examples usage:
Not tested with Alonzo yet, because the mainnet chain (that this tool was tested with) does not yet hold alonzo blocks.