Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max known PV is now the Alonzo PV. #3347

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Max known PV is now the Alonzo PV. #3347

merged 1 commit into from
Sep 14, 2021

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Sep 13, 2021

Currently was set to Mary, but worked because this was set one too high.

@nc6
Max known PV is now the Alonzo PV.
3852a62 
Currently was set to Mary, but worked because this was set one too high.
@nc6 nc6 requested a review from nfrisby September 13, 2021 21:43
jasagredo
jasagredo approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks completely reasonable to me. In fact, in ouroboros-consensus/docs/AddingAnEra.md it is clearly stated:

Don't forget to derive `maxMajorProtVer` from the new final era.

@nc6
Copy link
Contributor Author

nc6 commented Sep 14, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 14, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit e74388a into master Sep 14, 2021
@iohk-bors iohk-bors bot deleted the nc/alonzo-pv branch September 14, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasagredo jasagredo jasagredo approved these changes

@dnadales dnadales dnadales approved these changes

@nfrisby nfrisby Awaiting requested review from nfrisby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nc6 @dnadales @jasagredo