CAD-3444 handshake changes from p2p-master #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Sep 20, 2021
coot
commented
- handshake codec
- handshake: simplify types of client / server
- handshake: resiliant for simultanous open
- handshake: refactor the codec
- handshake: added test for a simultaneous open connections
- handshake: updated network-spec
- handshake: remove versioned application from HandshakeArguments
coot
changed the title
coot
force-pushed
the
coot/p2p-handshake
branch
from
102fb20
to
bbb013e
Compare
coot
force-pushed
the
coot/p2p-handshake
branch
from
bbb013e
to
49308c7
Compare
The following two changes make handshake codec behave the same way as all the other codecs: * make handshake decoder more strict: also check length of encoded data; * formatting of decoder errors
Unify the error type for handshake client and server.
Move decodeVersions to top level, next to encodeVersions.
This makes it easier to use HandshakeArguments in Diffusion
coot
force-pushed
the
coot/p2p-handshake
branch
from
49308c7
to
c3ea2e4
Compare
|
bors merge |
|
Build succeeded: |
coot
commented
Oct 4, 2021
| -- received as a copy of 'MsgProposeVersions' in a simultanous open | ||
| -- scenario. | ||
| -- | ||
| MsgProposeVersions' |
There was a problem hiding this comment.
MsgProposeVersionsSimultaneousOpen
coot
commented
Oct 4, 2021
ouroboros-network-framework/src/Ouroboros/Network/Protocol/Handshake/Type.hs
Show resolved
Hide resolved
coot
commented
Oct 4, 2021
iohk-bors bot
added a commit
that referenced
this pull request
Oct 7, 2021
3408: P2P review of merged PRs r=coot a=coot * #3369 * #3370 - snocket: move bang patterns to the top of the recursive call - snocket: fixed some typos - snocket: remote path for local sockets - handshake: renamed MsgProposeVersions' as MsgReplyVersions - handshake: test that acceptOrRefuse is symmetric - handshake: fixed some typos - handshake: implement more properties - handshake: updated documentation 3414: [CAD-3383] Show progress of --store-ledger every 1000 blocks r=EncodePanda a=EncodePanda Co-authored-by: Marcin Szamotulski <profunctor@pm.me> Co-authored-by: EncodePanda <paul.szulc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.