CAD-3444 typed-protocols changes from p2p-master #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Sep 20, 2021
coot
commented
- typed-protocols: added TokPeerRole
- typed-protocols: Codecs
- typed-protocols-cborg: CBOR codecs for typed-protocols
- typed-protocols-examples: added CBOR codecs
- typed-protocols: udpated upstream dependencies
coot
requested review from
bolt12,
EncodePanda,
karknu and
nfrisby
as code owners
A singleton type for PeerRole; It is useful when writing application code that can be shared between client and server.
Moved 'Network.TypedProtocol.Codec' module to typed-protocols package.
coot
force-pushed
the
coot/p2p-typed-protocols
branch
from
e0c7dbe
to
73a9f9e
Compare
coot
commented
Oct 6, 2021
coot
commented
Oct 6, 2021
Include CBOR codecs & tests for: * `PingPong` mini-protocol * `ReqResp` mini-protocol This patch makes `typed-protocols-examples` contain all the implementation details for `PingPong` and `ReqResp` protocols.
coot
force-pushed
the
coot/p2p-typed-protocols
branch
from
73a9f9e
to
1e048ad
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 15, 2021
3374: CAD-3444 typed-protocols changes from p2p-master r=coot a=coot - typed-protocols: added TokPeerRole - typed-protocols: Codecs - typed-protocols-cborg: CBOR codecs for typed-protocols - typed-protocols-examples: added CBOR codecs - typed-protocols: udpated upstream dependencies Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
|
Build failed: |
Updated: `ouroboros-network-framework`, `ouroboros-network` and `ouroboros-consensus` after restructuring `typed-protocols` packages.
coot
force-pushed
the
coot/p2p-typed-protocols
branch
from
1e048ad
to
89d5509
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.