-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --store-ledger option to db-analyser #3376
Conversation
2a30981
to
42cfe6a
Compare
I've just finished running the tool against longer chain that also holds alonzo blocks, and everything works as expected
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- what is
hasFS
set to, and does it make sense to always have a value? - can we avoid exposing new symbols in
OnDisk
- would it make sense to rename
storeLedgerX
functions tostoreLedgeStateAt
? - shouldn't snapshot taking stop at the specified slot number?
699b6f0
to
274a415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after discussing my comments with Pawel.
fcebb0f
to
61f7fac
Compare
bors merge |
Build succeeded: |
Consider a chain downloaded by cardano-node. While getting the chain, the default disk policy created two snapshots on disk
Now we can ask db-analyser to also create a snapshot of ledger at slot 13916582 - while processing the chain - and store it. The name of the file will be
13916582_db-analyser
.(please note that by providing a suffix _db-analyser we ensure that the snapshot will not be deleted by node in the future)
Once the node is done with its work we can see that the snapshot is created.
We can now compare if snapshot created by node is identical to the one created by db-analyser