Fix race condition in the thread tracking set #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible for threads to get "removed" before spawnOne had added the threads. This caused those threads to never get removed which would trigger ratelimiting and eventually the node would refuse to accept new connections. Change it so that if the thread isn't inserted yet we will wait for spawnOne to do it before we remove the thread. Thanks to @psychomb for helping troubleshoot this problem..
dcoutts
approved these changes
Sep 29, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for threads to get "removed" before spawnOne had added
the threads. This caused those threads to never get removed which would
trigger ratelimiting and eventually the node would refuse to accept new
connections.
Change it so that if the thread isn't inserted yet we will wait for
spawnOne to do it before we remove the thread.
Thanks to @psychomb for helping troubleshoot this problem.