Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap profiling tools #3471

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Heap profiling tools #3471

merged 5 commits into from
Nov 18, 2021

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Nov 3, 2021

Some additions to db-analyser to deal with heap profiling

@nc6 nc6 requested a review from EncodePanda November 3, 2021 11:48
@nc6 nc6 force-pushed the nc/heap-profiling branch from a9d3718 to b4dbbec Compare November 3, 2021 11:57
@nc6 nc6 marked this pull request as ready for review November 4, 2021 12:42
@nc6 nc6 requested review from nfrisby and a team as code owners November 4, 2021 12:42
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I made a few minor requests based on the fact that we'll probably need to, at some point, maintain/explain this code you wrote :)

Thanks! Especially happy to see the nothunks check in here.

@nfrisby
Copy link
Contributor

nfrisby commented Nov 9, 2021

FYI @EncodePanda I approved this. Review soon if you have any objections :D

nc6 and others added 2 commits November 18, 2021 15:55
In the end these were not needed, but they are simple and expand the
capabilities there.
@nc6 nc6 force-pushed the nc/heap-profiling branch from 70165d1 to a9e672e Compare November 18, 2021 14:56
nc6 and others added 3 commits November 18, 2021 15:57
Example usage:

```
cabal run db-analyser -- \
	--db ~/topos/iohk/cardano-node/state-node-mainnet/db-mainnet/ \
	--minimum-block-validation cardano \
	--configByron ~/Downloads/mainnet-byron-genesis.json \
	--configShelley ~/Downloads/mainnet-shelley-genesis.json \
	--configAlonzo ~/Downloads/mainnet-alonzo-genesis.json \
	--checkThunks 10000
```
Adds a mode to the db-analyser (`--trace-lgr`) which maintains a ledger
state and inserts appropriate markers into the event log at points
during the epoch. At the moment only the epoch boundary is marked.
@nc6 nc6 force-pushed the nc/heap-profiling branch from a9e672e to fadec1a Compare November 18, 2021 14:58
@nc6
Copy link
Contributor Author

nc6 commented Nov 18, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 18, 2021

@iohk-bors iohk-bors bot merged commit 51fcddb into master Nov 18, 2021
@iohk-bors iohk-bors bot deleted the nc/heap-profiling branch November 18, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants