Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pruning policy #3499

Merged
merged 3 commits into from
Nov 20, 2021
Merged

pruning policy #3499

merged 3 commits into from
Nov 20, 2021
+60 −58

Conversation

coot
Copy link
Contributor

@coot coot commented Nov 19, 2021

  • pruning: Ord instance of ConnectionType
  • pruning: move randomPrunePolicy to Ouroboros.Network.Diffusion.Policies
  • pruning: modify prune policy

@coot
pruning: Ord instance of ConnectionType
df4f6e5 
Make OutboundIdleConn order after InboundIdleConn; this has an impact on
simplePruningPolicy.
@coot coot requested a review from karknu as a code owner November 19, 2021 13:43
@coot coot added networking diffusion Issues / PRs related to diffusion layer labels Nov 19, 2021
coot added 2 commits November 19, 2021 16:31
@coot
pruning: move randomPrunePolicy to Ouroboros.Network.Diffusion.Policies
4b6144f
@coot
pruning: modify prune policy
7a90627 
If two peers are both upstream (or downstream) and have the same score,
order by their connection type.
@coot coot force-pushed the coot/prune-policy branch from c968214 to 7a90627 Compare November 19, 2021 15:32
karknu
karknu approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot
Copy link
Contributor Author

coot commented Nov 20, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 20, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 1892f82 into master Nov 20, 2021
@iohk-bors iohk-bors bot deleted the coot/prune-policy branch November 20, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karknu karknu karknu approved these changes

Assignees
No one assigned
Labels
diffusion Issues / PRs related to diffusion layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @karknu