Use block download when ranking peers #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
force-pushed
the
karknu/boup
branch
3 times, most recently
from
ce103fa
to
604104f
Compare
coot
approved these changes
Nov 23, 2021
| @@ -163,5 +163,24 @@ fetchyness = Pq.fold' count Map.empty | |||
| fn Nothing = Just $ fromIntegral bytes | |||
| fn (Just oldBytes) = Just $! oldBytes + fromIntegral bytes | |||
|
|
|||
| -- Returns a Map which counts the number of times a given peer | |||
| -- was the first we downloaded a block from. | |||
| fetchyness' | |||
There was a problem hiding this comment.
Could you rename fetchyness' maybe as fetchynessBlockCount and also rename fetchyness as fetchynessBytes. Or something like that.
Use both who ever gave us a header first, and who ever provided us with the block first when ranking peers in deadline mode. For larger blocks forged far away it is likely that we learned of the header from a node on another continent, but the node from which we first downloaded the block is much closer. This change gives both nodes credit.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use both who ever gave us a header first, and who ever provided us with
the block first when ranking peers in deadline mode. For larger blocks
forged far away it is likely that we learned of the header
from a node on another continent, but the node from which we first
downloaded the block is much closer. This change gives both nodes
credit.