Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement progress tracers for chunk validation #3506

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Implement progress tracers for chunk validation #3506

merged 1 commit into from
Nov 30, 2021
+63 −33

Conversation

jasagredo
Copy link
Contributor

Implements CAD-3715.

@jasagredo jasagredo removed the request for review from nfrisby November 24, 2021 15:18
@jasagredo jasagredo force-pushed the jasagredo/add-progress-tracers branch from 3a5bf0d to 548a0d6 Compare November 24, 2021 15:24
@jasagredo jasagredo mentioned this pull request Nov 24, 2021
Closed
@jasagredo jasagredo force-pushed the jasagredo/add-progress-tracers branch from 910255a to e620f6c Compare November 25, 2021 10:58
dnadales
dnadales reviewed Nov 25, 2021
View reviewed changes
Copy link
Member

@dnadales dnadales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss my remarks in today' sync meeting.

ouroboros-consensus/src/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Types.hs Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Types.hs Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Validation.hs Outdated Show resolved Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Types.hs Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the jasagredo/add-progress-tracers branch from 1a25f28 to 30eca48 Compare November 26, 2021 15:27
@jasagredo jasagredo force-pushed the jasagredo/add-progress-tracers branch from 30eca48 to ca13a6a Compare November 30, 2021 11:23
@jasagredo
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 30, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 2d675d4 into master Nov 30, 2021
@iohk-bors iohk-bors bot deleted the jasagredo/add-progress-tracers branch November 30, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EncodePanda EncodePanda EncodePanda approved these changes

@dnadales dnadales dnadales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasagredo @dnadales @EncodePanda