Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Peer Sharing to Wireshark dissector #4657

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Add Peer Sharing to Wireshark dissector #4657

merged 2 commits into from
Aug 25, 2023
+15 −2

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Aug 24, 2023

Description

Add peer sharing protocol to the ouroboros-network wireshark dissector.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@karknu karknu requested a review from coot as a code owner August 24, 2023 13:40
@bolt12 bolt12 self-requested a review August 24, 2023 13:45
@karknu
Update dissector for peer sharing
40abd36 
Update dissector for the peer sharing protocol.
@karknu
update changelog
fb1c1da
@karknu karknu force-pushed the karknu/dissector_peersharing branch from 64a91ca to fb1c1da Compare August 25, 2023 08:56
coot
coot approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @karknu.

@coot coot enabled auto-merge August 25, 2023 11:18
@coot coot added this pull request to the merge queue Aug 25, 2023
Merged via the queue into IntersectMBO:master with commit 829caf6 Aug 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@bolt12 bolt12 bolt12 approved these changes

Assignees

@karknu karknu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karknu @coot @bolt12