Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-2370: let minting policies take redeemers #3400

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

michaelpj
Copy link
Contributor

This is really only the beginning of this: it completely punts on
handling actually passing the redeemers around properly, instead just
conjuring () in all cases. The main point of this is so that
downstream can use our libraries to make minting policies that will work
with the real ledger, which will pass the extra argument (and does
already handle the redeemers).

I will make a follow-up PR for actually doing things properly, but it's
a bit of a rabbit-hole, so I thought I should get this one done first.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@michaelpj michaelpj requested a review from j-mueller June 18, 2021 17:16
This is really only the beginning of this: it completely punts on
handling actually passing the redeemers around properly, instead just
conjuring `()` in all cases. The main point of this is so that
downstream can use our libraries to make minting policies that will work
with the real ledger, which will pass the extra argument (and does
already handle the redeemers).

I will make a follow-up PR for actually doing things properly, but it's
a bit of a rabbit-hole, so I thought I should get this one done first.
@michaelpj michaelpj force-pushed the mpj/redeemer-minting-minimal branch from 07bc516 to c0f1932 Compare June 19, 2021 11:32
@michaelpj
Copy link
Contributor Author

I'm being pushy on this but do take a look later.

@michaelpj michaelpj merged commit 9e4d0bf into master Jun 19, 2021
@kwxm kwxm deleted the mpj/redeemer-minting-minimal branch October 12, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant