Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neurips paper formula #1

Open
aced125 opened this issue Dec 23, 2020 · 0 comments
Open

Neurips paper formula #1

aced125 opened this issue Dec 23, 2020 · 0 comments

Comments

@aced125
Copy link

aced125 commented Dec 23, 2020

Hi. Could you please explain how the log_prob function for the tensor ring induced prior works - mainly this line: https://github.com/insilicomedicine/TRIP/blob/master/core/learnable_priors/trip.py#L164

It seems to conflict with Algorithm 2 in the Neurips paper (https://arxiv.org/pdf/1910.13148.pdf), as in that algorithm, the log_probs are only calculated at the end, whereas in the code, it is updated at every iteration in the for loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant