Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwb build-react-app always returns with exit code of 0 #405

Closed
jstralko opened this issue Nov 27, 2017 · 2 comments
Closed

nwb build-react-app always returns with exit code of 0 #405

jstralko opened this issue Nov 27, 2017 · 2 comments
Labels

Comments

@jstralko
Copy link

jstralko commented Nov 27, 2017

This issue is a: Bug Report

node -v
v6.11.2
npm -v
3.10.10
nwb -v
v0.15.2

When running nwb build-react-app it always returns with exit code 0 regardless if there were errors or not. So my scripts don't get reported if there is an error.

i.e.

✖ Building React app

Failed to compile with 1 error.

ERROR in ./src/components/LineGraph.jsx
Module not found: Error: Can't resolve 'd3' in '/Volumes/Source/src/components'
@ ./src/components/LineGraph.jsx 19:0-25
@ ./src/index.js
@ multi /usr/local/lib/~/nwb/polyfills.js ./src/index.js

Then doing:
$>echo $?
0

It would be nice to get something other than 0 when there is an error.

@insin insin added bug support and removed bug labels Nov 29, 2017
@insin
Copy link
Owner

insin commented Nov 29, 2017

Just spotted the version - this was fixed for #290 in v0.17

@jstralko
Copy link
Author

jstralko commented Dec 5, 2017

Thank you very much!

@insin insin closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants