Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customized MSZ Option 57 instead of hard-coded 1500 #542

Open
w13915984028 opened this issue Jul 18, 2024 · 0 comments
Open

Allow customized MSZ Option 57 instead of hard-coded 1500 #542

w13915984028 opened this issue Jul 18, 2024 · 0 comments

Comments

@w13915984028
Copy link

The dhcp v4 client will set the MSZ Option 57 as 1500 always, instead, most clients use the default minimal value 576

MaxMessageSize = 1500

e.g.: A dhcp client from here:

16:13:25.070626 52:54:00:e1:2e:23 > ff:ff:ff:ff:ff:ff, ethertype IPv4 (0x0800), length 342: (tos 0x10, ttl 64, id 0, offset 0, flags [DF], proto UDP (17), length 328)
    0.0.0.0.68 > 255.255.255.255.67: [udp sum ok] BOOTP/DHCP, Request from 52:54:00:e1:2e:23, length 300, xid 0x49cc3e76, Flags [none] (0x0000)
	  Client-Ethernet-Address 52:54:00:e1:2e:23
	  Vendor-rfc1048 Extensions
	    Magic Cookie 0x63825363
	    DHCP-Message Option 53, length 1: Discover
	    Client-ID Option 61, length 19: hardware-type 255, 00:e1:2e:23:00:01:00:01:2e:2b:a9:b6:52:54:00:e1:2e:23
	    Parameter-Request Option 55, length 20: 
	      RN, RB, Subnet-Mask, BR
	      MTU, Classless-Static-Route, Default-Gateway, Static-Route
	      Option 119, Domain-Name, Domain-Name-Server, YD
	      YS, NTP, RP, Option 85
	      Option 86, Option 87, POSIX-TZ, TZ-Name
	    MSZ Option 57, length 2: 1500
	    Hostname Option 12, length 5: "harv2"

The ubuntu VM dhcp client:

    0.0.0.0.68 > 255.255.255.255.67: [udp sum ok] BOOTP/DHCP, Request from 52:54:00:ed:f1:a7, length 288, xid 0x3d01be60, secs 1, Flags [none] (0x0000)
	  Client-Ethernet-Address 52:54:00:ed:f1:a7
	  Vendor-rfc1048 Extensions
	    Magic Cookie 0x63825363
	    DHCP-Message Option 53, length 1: Discover
	    Client-ID Option 61, length 19: hardware-type 255, 56:50:4d:98:00:02:00:00:ab:11:d2:7c:59:26:b0:aa:ac:77
	    Parameter-Request Option 55, length 11: 
	      Subnet-Mask, Default-Gateway, Hostname, Domain-Name
	      Domain-Name-Server, MTU, Static-Route, Classless-Static-Route
	      Option 119, NTP, Option 120
	    MSZ Option 57, length 2: 576
	    Hostname Option 12, length 4: "wang"

In an issue, harvester/harvester#3428, we found the the first DHCPDiscover did not receive an response

The only notable difference is the Option 57 1500.

Could we allow the caller set this param, if set, the dhcp uses it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant