Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 4.0.0 deepEqual #25

Closed
aaronjensen opened this issue Sep 11, 2015 · 1 comment · Fixed by #65
Closed

Update to 4.0.0 deepEqual #25

aaronjensen opened this issue Sep 11, 2015 · 1 comment · Fixed by #65

Comments

@aaronjensen
Copy link

https://github.com/nodejs/LTS/wiki/Breaking-changes-between-v0.12-and-next-LTS-release#assert-check-object-prototype-in-assertdeepequal

nodejs/node#621

This changes the method semantics so it should be a major version bump like node did probably.

Will address mjackson/expect#17

@johman10
Copy link

For other people finding this issue.
This library has the option to sent in options and it accepts a strict mode.
To do what is requested here one can do:

import deepEqual from 'deep-equal';

const array = { test: ['1', '2', '3'] };
const array2 = { test: [1, 2, 3] };

deepEqual(array, array2) // false
deepEqual(array, array2, { strict: true }); // true

Related code can be found here: https://github.com/substack/node-deep-equal/blob/master/index.js#L17

Hope this helps others finding this an issue. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants