Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Crossplatform docker images #1394

Open
aaronweissler opened this issue Apr 14, 2022 · 2 comments
Open

[Feature] - Crossplatform docker images #1394

aaronweissler opened this issue Apr 14, 2022 · 2 comments
Labels
area/general enhancement New feature or request

Comments

@aaronweissler
Copy link
Member

aaronweissler commented Apr 14, 2022

Is your feature request related to a problem? Please describe.
When using an ARM-based processor, e.g. with an M1 Mac, the currently built docker images need to be run using emulation which leads to worse performance.

Describe the solution you'd like
Build and publish the docker images for both amd64 and arm using crossplatform builds.

@aaronweissler aaronweissler added the idea A rough idea for a feature or extension label Apr 14, 2022
@mariusoe mariusoe added enhancement New feature or request area/general and removed idea A rough idea for a feature or extension labels May 2, 2022
@aaronweissler aaronweissler self-assigned this May 2, 2022
@aaronweissler
Copy link
Member Author

aaronweissler commented May 30, 2022

buildx did not work with our CircleCI despite the remote-docker version supposedly supporting it. Will probably wait with this in favor of #1425, since implementing that change would render time spent troubleshooting this issue wasted.

@aaronweissler aaronweissler removed their assignment Sep 16, 2022
@aaronweissler
Copy link
Member Author

Unfortunately, the gradle plugin we are using for Docker builds currently does not fully support buildx as we would need it, either. Because you can only push buildx images immediately after building and due to how the plugin works internally, you can only build and push buildx images with one specific tag, so for example we could build and push only a latest image for each release or only an image with the version tag but not both..

Instead we could try to do it ourselves using CLI commands directly (the commands would be rather simple, the question with this mainly would be, whether we have access to Docker within the GitHub Action environment, but I think we should have) or using the official GitHub Action https://github.com/marketplace/actions/build-and-push-docker-images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/general enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants