Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User CRD] New finilizer to a deleting resource #532

Closed
ribaraka opened this issue Aug 23, 2023 · 1 comment · Fixed by #533
Closed

[User CRD] New finilizer to a deleting resource #532

ribaraka opened this issue Aug 23, 2023 · 1 comment · Fixed by #533
Assignees
Labels
refactor Code improvements or refactorings

Comments

@ribaraka
Copy link
Contributor

Our current logic ensures that when a user is attached to a cluster, a finalizer is added to the user to keep it from accidental removal and ensure healthy work. The flaw is when (accidentally) deleting a User with finalizers and you still want to work with the same user, there will be an issue to add the user yet to another cluster, k8s doesn’t allow adding new finalizers to deleting resources.

@ribaraka ribaraka self-assigned this Aug 23, 2023
@ribaraka ribaraka added the refactor Code improvements or refactorings label Aug 23, 2023
@worryg0d
Copy link
Collaborator

It doesn't look like a bug, it's common k8s behavior when the resource is being deleted. Even kubectl reports when someone tries to update a resource in this state.
But for better UX maybe this is a good idea to omit adding those cluster-specific finalizers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code improvements or refactorings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants