issue-467, use the latest clusters version for packaged provisioning was implemented #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoodgeMatvey
force-pushed
the
issue-467
branch
2 times, most recently
from
6753995
to
12bb4e5
Compare
testisnullus
requested changes
Jul 13, 2023
controllers/clusters/helpers.go
Outdated
| func getSortedAppVersions(versions []*models.AppVersions, appType string) []*version.Version { | ||
| for _, apps := range versions { | ||
| if apps.Application == appType { | ||
| versions := make([]*version.Version, len(apps.Versions)) |
There was a problem hiding this comment.
Let's rename the versions array to newVersions or something similar
controllers/clusters/helpers.go
Outdated
| for _, apps := range versions { | ||
| if apps.Application == appType { | ||
| versions := make([]*version.Version, len(apps.Versions)) | ||
| for i, raw := range apps.Versions { |
There was a problem hiding this comment.
Let's rename raw to version, wdyt?
testisnullus
approved these changes
Jul 13, 2023
ribaraka
reviewed
Jul 13, 2023
| @@ -48,7 +48,7 @@ type OpenSearchSpec struct { | |||
| NotificationsPlugin bool `json:"notificationsPlugin,omitempty"` | |||
| AnomalyDetectionPlugin bool `json:"anomalyDetectionPlugin,omitempty"` | |||
| LoadBalancer bool `json:"loadBalancer,omitempty"` | |||
| ClusterManagerNodes []*ClusterManagerNodes `json:"clusterManagerNodes"` | |||
| ClusterManagerNodes []*ClusterManagerNodes `json:"clusterManagerNodes,omitempty"` | |||
There was a problem hiding this comment.
@RostislavPorohnya said that we need it for restore operations
ribaraka
approved these changes
Jul 13, 2023
taaraora
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #467