Added users graceful creation during OpenSearch cluster creation phase #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribaraka
requested changes
Jul 19, 2023
| } | ||
|
|
||
| if o.Status.State != models.RunningStatus { | ||
| return fmt.Errorf("cluster is not is the running state") |
There was a problem hiding this comment.
please make it a log info message and add the word "yet" at the end
Comment on lines
816
to
826
| err := r.Get(ctx, types.NamespacedName{ | ||
| Namespace: o.Namespace, | ||
| Name: o.Name, | ||
| }, o) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
please remove the job if a resource is not found
| for _, ref := range o.Spec.UserRefs { | ||
| err = r.createUser(ctx, logger, o, ref) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
please add here an error log and event
worryg0d
force-pushed
the
issue-439-users-graceful-creation-during-cluster-creation
branch
from
1de7821
to
cb13b26
Compare
worryg0d
force-pushed
the
issue-439-users-graceful-creation-during-cluster-creation
branch
from
cb13b26
to
f9d725d
Compare
ribaraka
approved these changes
Jul 19, 2023
testisnullus
requested changes
Jul 19, 2023
| }, o) | ||
| if err != nil { | ||
| if k8serrors.IsNotFound(err) { | ||
| logger.Info("OpenSearch cluster resource is not found. Closing user creation job...") |
There was a problem hiding this comment.
Closing user creation job... -> Removing/Stopping user creation job..., wdyt?
| for _, ref := range o.Spec.UserRefs { | ||
| err = r.createUser(ctx, logger, o, ref) | ||
| if err != nil { | ||
| logger.Info("Failed to create user on the cluster", |
There was a problem hiding this comment.
Failed to create a user on the cluster -> Failed to create a user for the cluster
worryg0d
force-pushed
the
issue-439-users-graceful-creation-during-cluster-creation
branch
from
f9d725d
to
c81bc1e
Compare
worryg0d
force-pushed
the
issue-439-users-graceful-creation-during-cluster-creation
branch
from
c81bc1e
to
244885d
Compare
testisnullus
approved these changes
Jul 20, 2023
taaraora
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented graceful creation of users when the OpenSearch cluster is not in the running state. Now it starts a job that checks if a cluster is in the running state and then creates users and removes itself.