Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-490, implementation for credentials lifecycle for ZooKeeper #493

Merged
merged 1 commit into from
Jul 26, 2023
Merged

issue-490, implementation for credentials lifecycle for ZooKeeper #493

merged 1 commit into from
Jul 26, 2023

Conversation

OleksiienkoMykyta
Copy link
Collaborator

@OleksiienkoMykyta OleksiienkoMykyta commented Jul 24, 2023 •
edited
Loading

Closes #490

@OleksiienkoMykyta OleksiienkoMykyta added the enhancement New feature or request label Jul 24, 2023
@OleksiienkoMykyta OleksiienkoMykyta changed the title [WIP]issue-490, implementation for credentials lifecycle for ZooKeeper issue-490, implementation for credentials lifecycle for ZooKeeper Jul 25, 2023
RostislavPorohnya
RostislavPorohnya requested changes Jul 25, 2023
View reviewed changes
apis/clusters/v1beta1/zookeeper_types.go Outdated

v1 "k8s.io/api/core/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont use alias

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

pkg/instaclustr/client.go Outdated
Comment on lines 2206 to 2211
type credentials struct {
Username string `json:"username"`
InstaclustrUserPassword string `json:"instaclustrUserPassword"`
}

var creds credentials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use anonymous struct:

Suggested change
type credentials struct {
Username string `json:"username"`
InstaclustrUserPassword string `json:"instaclustrUserPassword"`
}
var creds credentials
creds := &struct {
Username string `json:"username"`
InstaclustrUserPassword string `json:"instaclustrUserPassword"`
} {}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@OleksiienkoMykyta OleksiienkoMykyta force-pushed the issue-490-implementation-for-credentials-lifecycle-for-ZooKeeper branch from b7a21a7 to b304743 Compare July 25, 2023 15:03
@OleksiienkoMykyta OleksiienkoMykyta force-pushed the issue-490-implementation-for-credentials-lifecycle-for-ZooKeeper branch from b304743 to 144df72 Compare July 25, 2023 15:16
@OleksiienkoMykyta OleksiienkoMykyta merged commit 4e9c9c8 into main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worryg0d worryg0d worryg0d approved these changes

@ribaraka ribaraka ribaraka approved these changes

@RostislavPorohnya RostislavPorohnya RostislavPorohnya approved these changes

@taaraora taaraora taaraora approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement credentials lifecycle for ZooKeeper
5 participants
@OleksiienkoMykyta @taaraora @RostislavPorohnya @ribaraka @worryg0d