User creation job removing bug #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribaraka
approved these changes
Jul 26, 2023
tengu-alt
approved these changes
Jul 26, 2023
worryg0d
force-pushed
the
issue-499-user-creation-removing-job-bug-fix
branch
from
81e40e0
to
dcbb24f
Compare
testisnullus
approved these changes
Jul 26, 2023
taaraora
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug, when the user creation job removes itself and then doesn't unlock Mutex.
It happens because a job tries to write in a
donechannel and thenselectreceives a signal from thedonechannel. When it receives a signal from thedoneit finishes the current goroutine without unlocking the mutex.closes #499