Validation for cloud provider settings was added #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testisnullus
requested review from
DoodgeMatvey,
RostislavPorohnya and
ribaraka
testisnullus
changed the title
ribaraka
reviewed
Aug 31, 2023
apis/clusters/v1beta1/validation.go
Outdated
| networkMatched, err := regexp.Match(models.PeerSubnetsRegExp, []byte(dc.Network)) | ||
| if !networkMatched || err != nil { | ||
| return fmt.Errorf("the provided CIDR: %s must contain four dot separated parts and form the Private IP address. All bits in the host part of the CIDR must be 0. Suffix must be between 16-28. %v", dc.Network, err) | ||
| if dc.ProviderAccountName == "INSTACLUSTR" && len(dc.CloudProviderSettings) != 0 { |
There was a problem hiding this comment.
please use a const DefaultAccountName instead of hardcode
ribaraka
approved these changes
Aug 31, 2023
testisnullus
force-pushed
the
cloud-provider-settings-fix
branch
from
f7130b7
to
754cd7f
Compare
worryg0d
approved these changes
Sep 1, 2023
DoodgeMatvey
approved these changes
Sep 1, 2023
tengu-alt
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.