Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling no external IPs or private cluster for PostgreSQL users is implemented #582

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Handling no external IPs or private cluster for PostgreSQL users is implemented #582

merged 1 commit into from
Oct 5, 2023

Conversation

DoodgeMatvey
Copy link
Contributor

Closes #581

@DoodgeMatvey DoodgeMatvey added the enhancement New feature or request label Oct 2, 2023
@DoodgeMatvey DoodgeMatvey self-assigned this Oct 2, 2023
@DoodgeMatvey DoodgeMatvey changed the title issue-581, handling no external IPs or private cluster for PostgreSQL users is implemented handling no external IPs or private cluster for PostgreSQL users is implemented Oct 2, 2023
@DoodgeMatvey DoodgeMatvey changed the title handling no external IPs or private cluster for PostgreSQL users is implemented Handling no external IPs or private cluster for PostgreSQL users is implemented Oct 2, 2023
tengu-alt
tengu-alt reviewed Oct 2, 2023
View reviewed changes
controllers/clusters/postgresql_controller.go Outdated
return models.ReconcileRequeue
}

externalIPExists := false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

externalIPExists := false -> var externalIPExists bool default value will be false wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, both are good, changed

@DoodgeMatvey DoodgeMatvey force-pushed the issue-581-handle-private-cluster branch from b149c67 to c5b6d46 Compare October 2, 2023 14:25
@DoodgeMatvey DoodgeMatvey force-pushed the issue-581-handle-private-cluster branch from c5b6d46 to 78e0d67 Compare October 2, 2023 14:28
@DoodgeMatvey DoodgeMatvey merged commit a6f9412 into main Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worryg0d worryg0d worryg0d approved these changes

@tengu-alt tengu-alt tengu-alt approved these changes

@testisnullus testisnullus testisnullus approved these changes

@ribaraka ribaraka ribaraka approved these changes

@RostislavPorohnya RostislavPorohnya Awaiting requested review from RostislavPorohnya

@OleksiienkoMykyta OleksiienkoMykyta Awaiting requested review from OleksiienkoMykyta

Assignees

@DoodgeMatvey DoodgeMatvey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle no external IPs or private cluster for PostgreSQL users
5 participants
@DoodgeMatvey @ribaraka @testisnullus @tengu-alt @worryg0d