issue-544, refactor externalChanges message #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribaraka
reviewed
Dec 1, 2023
controllers/clusters/helpers.go
Outdated
| } | ||
|
|
||
| if len(ignoreFields) == 0 { | ||
| return string(k8sSpecJson), nil |
There was a problem hiding this comment.
You can just return bytes in this func
ribaraka
reviewed
Dec 1, 2023
controllers/clusters/helpers.go
Outdated
| @@ -158,8 +158,36 @@ func getSortedAppVersions(versions []*models.AppVersions, appType string) []*ver | |||
| return nil | |||
| } | |||
|
|
|||
| func removeRedundantFieldsFromSpec(k8sSpec interface{}, ignoreFields ...string) (string, error) { | |||
There was a problem hiding this comment.
we use any as for interface{}
ribaraka
requested changes
Dec 1, 2023
controllers/clusters/helpers.go
Outdated
| } | ||
|
|
||
| k8sSpecMap := map[string]interface{}{} | ||
| err = json.Unmarshal([]byte(string(k8sSpecJson)), &k8sSpecMap) |
There was a problem hiding this comment.
Suggested change
| err = json.Unmarshal([]byte(string(k8sSpecJson)), &k8sSpecMap) | |
| err = json.Unmarshal(k8sSpecJson, &k8sSpecMap) |
try this. less conversions and it looks cleaner.
controllers/clusters/helpers.go
Outdated
| return string(k8sSpecJson), nil | ||
| } | ||
|
|
||
| k8sSpecMap := map[string]interface{}{} |
OleksiienkoMykyta
force-pushed
the
issue-544-refactor-externalChanges-message
branch
from
fe82e0b
to
5bf22c0
Compare
OleksiienkoMykyta
force-pushed
the
issue-544-refactor-externalChanges-message
branch
from
5bf22c0
to
93e0294
Compare
ribaraka
approved these changes
Dec 5, 2023
testisnullus
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.