Issue-561, Additional columns printers #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
force-pushed
the
issue-561
branch
2 times, most recently
from
6be5ad8
to
f6b7139
Compare
…, clusterresources and kafkamanagement groups
worryg0d
requested review from
ribaraka,
testisnullus,
tengu-alt and
OleksiienkoMykyta
testisnullus
approved these changes
Dec 11, 2023
DoodgeMatvey
requested changes
Dec 11, 2023
| @@ -39,6 +39,10 @@ type AWSEncryptionKeyStatus struct { | |||
|
|
|||
| //+kubebuilder:object:root=true | |||
| //+kubebuilder:subresource:status | |||
| //+kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp" | |||
There was a problem hiding this comment.
Its not age, it is creationTimestamp. Age is timeNow - creationTimestamp
There was a problem hiding this comment.
You're right, but there is no way to do arithmetical operations for printing columns. But the way to show the age of a resource is to use .metadata.creationTimestamp and type date. You may see an example here. Kubectl does the same thing for all CRDs if there are no additional column printers.
There was a problem hiding this comment.
Strange a bit, but ok
tengu-alt
approved these changes
Dec 11, 2023
DoodgeMatvey
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional columns printers for groups:
clusterresourcesclusterskafkamanagementref #561