Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor image workflows to parallel matrix #363

Conversation

Gregory-Pereira
Copy link
Collaborator

This PR, while does not speedup our workflows, makes it considerably less code, and easier to update. We should consider if we want something like this conceptually.

@Gregory-Pereira
Copy link
Collaborator Author

going to move this as an upstream pr for testing purposes

@Gregory-Pereira
Copy link
Collaborator Author

moved to: #364

Copy link

mergify bot commented Nov 20, 2024

⚠️ The sha of the head commit of this PR conflicts with #364. Mergify cannot evaluate rules on this PR. ⚠️

@Gregory-Pereira Gregory-Pereira force-pushed the streamline-release-images-workflow branch from 95f7c3d to 90c1236 Compare November 20, 2024 23:14
@Gregory-Pereira Gregory-Pereira force-pushed the streamline-release-images-workflow branch from 90c1236 to 1b987b6 Compare November 20, 2024 23:19
@Gregory-Pereira
Copy link
Collaborator Author

@Gregory-Pereira Gregory-Pereira force-pushed the streamline-release-images-workflow branch from 1b987b6 to 5086bc7 Compare November 20, 2024 23:22
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira force-pushed the streamline-release-images-workflow branch from 5086bc7 to 0e2d36c Compare November 26, 2024 14:25
@Gregory-Pereira Gregory-Pereira marked this pull request as ready for review November 26, 2024 14:25
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 68fa485 into instructlab:main Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants