Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Disable Keyboard Shortcuts" does not disable Studio embedded video keyboard shortcuts #2445

Open
s1050613 opened this issue Jan 30, 2025 · 0 comments

Comments

@s1050613
Copy link

Summary

Even if the "Disable Keyboard Shortcuts" user setting is enabled, using the keyboard shortcuts CTRL+0, CTRL+1, ... , CTRL+9 while focus is on an <iframe> displaying an embedded Studio video will cause the video to jump to a certain point in time.

These keyboard shortcuts are common in web browser to change tabs quickly. Hence, if users use this keyboard shortcuts with focus on a Studio video, the user will lose their previous time in the video, instead of changing tabs as intended.

Steps to reproduce

  1. With the "Disable Keyboard Shortcuts" setting disabled, open a page with an embedded Studio video.
  2. Play the video.
  3. Press the keyboard shortcuts CTRL+0-9.
  4. Enable the "Disable Keyboard Shortcuts" setting, and reload the page with the embedded studio video.
  5. Repeat steps 2-3.
  6. Observe that, regardless of the state of the setting, Studio will interpret these keyboard shortcuts.

Expected behaviour

When the "Disable Keyboard Shortcuts" user setting is enabled, CTRL+0-9 will have no effect on embedded Studio video players.

Additional notes

It may be beneficial to show what parts of embedded videos users have watched, in a way similar to how Bilibili displays this information. This would allow users to quickly find their spot in the video if they lose it with the "Disable Keyboard Shortcuts" setting disabled, or accidentally click to another part of the video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant