Fuse install happens for every run/re-run of the installer

[david-martin]

Logs during a re-run of installer

TASK [fuse_managed : Create fuse namespace if it doesn't exist] ****************
changed: [127.0.0.1]

TASK [fuse_managed : Add labels to namespace] **********************************
changed: [127.0.0.1]

TASK [fuse_managed : Create Syndesis CRD] **************************************
changed: [127.0.0.1]

TASK [fuse_managed : Create Fuse image streams] ********************************
changed: [127.0.0.1]

TASK [fuse_managed : Create fuse Operator resources in fuse] *******************
changed: [127.0.0.1]

TASK [fuse_managed : template] *************************************************
ok: [127.0.0.1]

TASK [fuse_managed : Create Syndesis custom resource in fuse] ******************
changed: [127.0.0.1]

TASK [fuse_managed : Verify Fuse deployment succeeded] *************************

Looks like there are no when clauses in https://github.com/integr8ly/installation/blob/master/evals/roles/fuse_managed/tasks/main.yml

This causes a recreate of the operator & reinstall due to oc apply being used

[david-martin]

@aidenkeating Do you recall if there is a reason we use oc apply here https://github.com/integr8ly/installation/blob/master/evals/roles/fuse_managed/tasks/main.yml#L24

[david-martin]

I'm not sure why yet, but re-running install results in a timeout on the ready pod count (4 != 7)
I've seen this happen at least twice recently

NAME                          READY     STATUS             RESTARTS   AGE
syndesis-db-1-96fmm           0/1       Pending            0          7m
syndesis-db-1-deploy          1/1       Running            0          7m
syndesis-meta-1-4rzqc         0/1       Pending            0          7m
syndesis-meta-1-deploy        1/1       Running            0          7m
syndesis-oauthproxy-1-r6dz5   1/1       Running            0          7m
syndesis-operator-1-8jccs     1/1       Running            0          18m
syndesis-prometheus-1-dzjjp   1/1       Running            0          7m
syndesis-server-1-deploy      1/1       Running            0          7m
syndesis-server-1-rbk8j       0/1       CrashLoopBackOff   5          7m
syndesis-ui-1-fgg9j           1/1       Running            0          7m
todo-1-build                  0/1       Completed          0          7m
todo-1-ppg5b                  1/1       Running            0          7m

FAILED - RETRYING: Verify Fuse deployment succeeded (1 retries left).
fatal: [127.0.0.1]: FAILED! => {"attempts": 50, "changed": false, "cmd": "oc get pods -n fuse --selector=\"app=syndesis\" -o jsonpath='{.items[*].status.containerStatuses[?(@.ready==true)].ready}' | wc -w", "delta": "0:00:00.209498", "end": "2019-02-26 21:44:55.285794", "rc": 0, "start": "2019-02-26 21:44:55.076296", "stderr": "", "stderr_lines": [], "stdout": "4", "stdout_lines": ["4"]}

PLAY RECAP *********************************************************************
127.0.0.1                  : ok=247  changed=117  unreachable=0    failed=1   
master1.waterford-3084.internal : ok=8    changed=5    unreachable=0    failed=0   

[aidenkeating]

@david-martin Looks like this was a misunderstanding on my part of what oc apply does, I'll make a PR to fix this