Adding merge types to repository resource #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey -- boring? This was my first contribution to Terraform! Far from boring! |
|
"Exciting" code scares me. I'll take boring any day! I think we're waiting on the provider migration to finish and then this can get merged. |
|
Hi @taiidani Thanks for the work here - I had to make 1 change to the tests. When i ran the tests in their form, I got the following: So I updated the tests :) Thanks Paul |
ghost
mentioned this pull request
frbayart
added a commit
to frbayart/terraform-provider-github
that referenced
this pull request
Dec 6, 2020
jcudit
pushed a commit
that referenced
this pull request
Dec 18, 2020
* Added `allowsDeletions`and `allowsForcePushes`settings https://developer.github.com/v4/changelog/2020-11-13-schema-changes/ (#1) * complete documentation * update module github.com/shurcooL/githubv4 with `go get github.com/shurcooL/githubv4` * vendor latest githubv4 * add test for deletions and force pushes Co-authored-by: Jeremy Udit <jcudit@github.com>
This was referenced Jun 16, 2023
This was referenced Aug 15, 2023
1 task
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
) * Added `allowsDeletions`and `allowsForcePushes`settings https://developer.github.com/v4/changelog/2020-11-13-schema-changes/ (integrations#1) * complete documentation * update module github.com/shurcooL/githubv4 with `go get github.com/shurcooL/githubv4` * vendor latest githubv4 * add test for deletions and force pushes Co-authored-by: Jeremy Udit <jcudit@github.com>
kfcampbell
pushed a commit
that referenced
this pull request
Mar 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding merge types to the GitHub Repository resource so that users can control when the repository allows Squash merges, Rebase merges and/or Merge commits.
Imported from hashicorp/terraform#15230
Fixes hashicorp/terraform#15183
Fixes #14