Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/github_ip_ranges: Add importer IPs #100

Merged
merged 1 commit into from
Aug 3, 2018
Merged

data-source/github_ip_ranges: Add importer IPs #100

merged 1 commit into from
Aug 3, 2018

Conversation

sudomateo
Copy link

I'm adding the importer IP addresses since google/go-github#881 was merged.

@paultyng
Copy link
Contributor

paultyng commented Jun 7, 2018

Will merge once I get a chance to confirm acceptance tests.

@radeksimko radeksimko added the Type: Feature New feature or request label Aug 2, 2018
@radeksimko radeksimko changed the title Add importer IPs data-source/github_ip_ranges: Add importer IPs Aug 2, 2018
Copy link
Contributor

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudomateo Sorry for the delay.

I can confirm that acceptance test are passing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./github -v  -timeout 120m
=== RUN   TestAccGithubIpRangesDataSource_existing
--- PASS: TestAccGithubIpRangesDataSource_existing (1.01s)
=== RUN   TestAccGithubTeamDataSource_noMatchReturnsError
--- PASS: TestAccGithubTeamDataSource_noMatchReturnsError (0.32s)
=== RUN   TestAccGithubUserDataSource_noMatchReturnsError
--- PASS: TestAccGithubUserDataSource_noMatchReturnsError (0.13s)
=== RUN   TestAccGithubUserDataSource_existing
--- PASS: TestAccGithubUserDataSource_existing (2.33s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccGithubBranchProtection_basic
--- PASS: TestAccGithubBranchProtection_basic (7.44s)
=== RUN   TestAccGithubBranchProtection_emptyItems
--- PASS: TestAccGithubBranchProtection_emptyItems (5.26s)
=== RUN   TestAccGithubBranchProtection_importBasic
--- PASS: TestAccGithubBranchProtection_importBasic (5.38s)
=== RUN   TestAccGithubIssueLabel_basic
--- PASS: TestAccGithubIssueLabel_basic (5.58s)
=== RUN   TestAccGithubIssueLabel_existingLabel
--- PASS: TestAccGithubIssueLabel_existingLabel (4.56s)
=== RUN   TestAccGithubIssueLabel_importBasic
--- PASS: TestAccGithubIssueLabel_importBasic (3.69s)
=== RUN   TestAccGithubMembership_basic
--- PASS: TestAccGithubMembership_basic (1.69s)
=== RUN   TestAccGithubMembership_importBasic
--- PASS: TestAccGithubMembership_importBasic (1.36s)
=== RUN   TestAccGithubOrganizationWebhook_basic
--- PASS: TestAccGithubOrganizationWebhook_basic (2.07s)
=== RUN   TestAccGithubRepositoryCollaborator_basic
--- PASS: TestAccGithubRepositoryCollaborator_basic (5.26s)
=== RUN   TestAccGithubRepositoryCollaborator_importBasic
--- PASS: TestAccGithubRepositoryCollaborator_importBasic (3.87s)
=== RUN   TestAccGithubRepositoryDeployKey_basic
--- PASS: TestAccGithubRepositoryDeployKey_basic (4.03s)
=== RUN   TestAccGithubRepositoryDeployKey_importBasic
--- PASS: TestAccGithubRepositoryDeployKey_importBasic (3.03s)
=== RUN   TestAccGithubRepository_basic
--- FAIL: TestAccGithubRepository_basic (2.01s)
	testing.go:518: Step 0 error: Check failed: Check 1/2 error: GET https://api.github.com/repos/terraformtesting/tf-acc-test-jj7tq0rlog: 404 Not Found []
=== RUN   TestAccGithubRepository_archive
--- PASS: TestAccGithubRepository_archive (3.15s)
=== RUN   TestAccGithubRepository_archiveUpdate
--- PASS: TestAccGithubRepository_archiveUpdate (3.93s)
=== RUN   TestAccGithubRepository_importBasic
--- PASS: TestAccGithubRepository_importBasic (4.36s)
=== RUN   TestAccGithubRepository_defaultBranch
--- PASS: TestAccGithubRepository_defaultBranch (5.37s)
=== RUN   TestAccGithubRepository_templates
--- FAIL: TestAccGithubRepository_templates (2.83s)
	testing.go:579: Error destroying resource! WARNING: Dangling resources
		may exist. The full state and error is shown below.

		Error: Check failed: Repository terraformtesting/tf-acc-test-annilkh62j still exists

		State: <no state>
=== RUN   TestAccGithubRepository_topics
--- PASS: TestAccGithubRepository_topics (7.05s)
=== RUN   TestAccGithubRepositoryWebhook_basic
--- PASS: TestAccGithubRepositoryWebhook_basic (5.41s)
=== RUN   TestAccGithubRepositoryWebhook_importBasic
--- PASS: TestAccGithubRepositoryWebhook_importBasic (3.38s)
=== RUN   TestAccGithubTeamMembership_basic
--- PASS: TestAccGithubTeamMembership_basic (5.19s)
=== RUN   TestAccGithubTeamMembership_importBasic
--- PASS: TestAccGithubTeamMembership_importBasic (2.19s)
=== RUN   TestAccGithubTeamRepository_basic
--- PASS: TestAccGithubTeamRepository_basic (4.56s)
=== RUN   TestAccGithubTeamRepository_importBasic
--- PASS: TestAccGithubTeamRepository_importBasic (3.20s)
=== RUN   TestAccCheckGetPermissions
--- PASS: TestAccCheckGetPermissions (0.00s)
=== RUN   TestAccGithubTeam_basic
--- PASS: TestAccGithubTeam_basic (3.08s)
=== RUN   TestAccGithubTeam_hierarchical
--- PASS: TestAccGithubTeam_hierarchical (5.60s)
=== RUN   TestAccGithubTeam_importBasic
--- PASS: TestAccGithubTeam_importBasic (1.30s)
=== RUN   TestAccGithubUtilRole_validation
--- PASS: TestAccGithubUtilRole_validation (0.00s)
=== RUN   TestAccGithubUtilTwoPartID
--- PASS: TestAccGithubUtilTwoPartID (0.00s)
=== RUN   TestAccValidateTwoPartID
=== RUN   TestAccValidateTwoPartID/valid
=== RUN   TestAccValidateTwoPartID/blank_ID
=== RUN   TestAccValidateTwoPartID/not_enough_parts
=== RUN   TestAccValidateTwoPartID/too_many_parts
--- PASS: TestAccValidateTwoPartID (0.00s)
    --- PASS: TestAccValidateTwoPartID/valid (0.00s)
    --- PASS: TestAccValidateTwoPartID/blank_ID (0.00s)
    --- PASS: TestAccValidateTwoPartID/not_enough_parts (0.00s)
    --- PASS: TestAccValidateTwoPartID/too_many_parts (0.00s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-github/github	119.792s

Failures are just intermittent and related to the eventually consistent nature of the API (or Github's backend storage backing the API).

@radeksimko radeksimko merged commit 658dc0a into integrations:master Aug 3, 2018
@sudomateo sudomateo deleted the add-importer-ips branch August 30, 2018 19:22
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
data-source/github_ip_ranges: Add importer IPs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants