Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: github_repositories #129

Merged
merged 1 commit into from
Aug 13, 2018
Merged

New Data Source: github_repositories #129

merged 1 commit into from
Aug 13, 2018

Conversation

radeksimko
Copy link
Contributor

Closes #61

TF_ACC=1 go test ./github -v -run=TestAccGithubRepositoriesDataSource_ -timeout 120m
=== RUN   TestAccGithubRepositoriesDataSource_basic
--- PASS: TestAccGithubRepositoriesDataSource_basic (4.21s)
=== RUN   TestAccGithubRepositoriesDataSource_noMatch
--- PASS: TestAccGithubRepositoriesDataSource_noMatch (0.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	5.150s

tombuildsstuff
tombuildsstuff approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

website/docs/d/repositories.html.markdown

```hcl
data "github_repositories" "example" {
query = "org:hashicorp language:Go"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd question whether we want to also expose these as properties on the data source (e.g. org / language)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I don't think there's any strong enough use case that would justify creating (and maintaining) a custom parser for a fairly non-trivial query syntax, or did you have any particular one in mind?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, I was just thinking out loud :)

@radeksimko radeksimko merged commit 955cd25 into master Aug 13, 2018
@radeksimko radeksimko deleted the f-repositories-ds branch August 13, 2018 08:09
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@radeksimko
Merge pull request integrations#129 from terraform-providers/f-reposi…
6d80d42 
…tories-ds

New Data Source: github_repositories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
New data source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @tombuildsstuff