Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/github_team: Expose slug (and document when to use it) #136

Merged
merged 3 commits into from
Aug 16, 2018

Conversation

radeksimko
Copy link
Contributor

@radeksimko radeksimko commented Aug 16, 2018

Fixes #84

I'm labelling this as enhancement, as it's technically not a provider bug, but rather API bug, or undocumented behaviour.

The API silently ignores invalid team names, which can be either:

  • teams which simply don't exist
  • teams which don't have access to the repository
  • valid team names, instead of slugs
TF_ACC=1 go test ./github -v -run=TestAccGithubBranchProtection_ -timeout 120m
=== RUN   TestAccGithubBranchProtection_basic
--- PASS: TestAccGithubBranchProtection_basic (5.68s)
=== RUN   TestAccGithubBranchProtection_teams
--- PASS: TestAccGithubBranchProtection_teams (10.49s)
=== RUN   TestAccGithubBranchProtection_emptyItems
--- PASS: TestAccGithubBranchProtection_emptyItems (4.38s)
=== RUN   TestAccGithubBranchProtection_importBasic
--- PASS: TestAccGithubBranchProtection_importBasic (3.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	24.470s
TF_ACC=1 go test ./github -v -run=TestAccGithubTeam_ -timeout 120m
=== RUN   TestAccGithubTeam_basic
--- PASS: TestAccGithubTeam_basic (3.49s)
=== RUN   TestAccGithubTeam_slug
--- PASS: TestAccGithubTeam_slug (1.22s)
=== RUN   TestAccGithubTeam_hierarchical
--- PASS: TestAccGithubTeam_hierarchical (2.56s)
=== RUN   TestAccGithubTeam_importBasic
--- PASS: TestAccGithubTeam_importBasic (1.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	8.545s

I have sent the above feedback to GitHub via their contact page as advised in the docs.

@radeksimko radeksimko added the Type: Feature New feature or request label Aug 16, 2018
@radeksimko radeksimko changed the title github_team: Expose slug (and document when to use it) resource/github_team: Expose slug (and document when to use it) Aug 16, 2018
@radeksimko radeksimko merged commit f417c82 into master Aug 16, 2018
@radeksimko radeksimko deleted the f-team-expose-slug branch August 16, 2018 21:25
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
…xpose-slug

resource/github_team: Expose slug (and document when to use it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants