Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not to recreate labels when update #288

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Fix not to recreate labels when update #288

merged 1 commit into from
Mar 3, 2020

Conversation

shouichi
Copy link
Contributor

Close #173.

@ghost ghost added the size/S label Oct 21, 2019
@radeksimko radeksimko added the Type: Bug Something isn't working as documented label Dec 4, 2019
jcudit
jcudit approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@jcudit jcudit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve got this queued to validate the tests pass. Hopefully this merges this week.

Thanks for your patience and effort on this one.

@jcudit jcudit self-assigned this Jan 28, 2020
@shouichi shouichi force-pushed the fix-not-to-recreate-label branch from 4806d30 to 8ddc44c Compare March 3, 2020 00:09
@shouichi shouichi force-pushed the fix-not-to-recreate-label branch from 8ddc44c to f7b4477 Compare March 3, 2020 00:16
@shouichi
Copy link
Contributor Author

shouichi commented Mar 3, 2020

@jcudit Hi, can this be merged? It's approved and tests are passed.

@jcudit jcudit merged commit 39def66 into integrations:master Mar 3, 2020
@shouichi shouichi deleted the fix-not-to-recreate-label branch March 3, 2020 00:53
@anGie44 anGie44 mentioned this pull request Apr 19, 2020
Closed
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Merge pull request integrations#288 from shouichi/fix-not-to-recreate…
d30d6d0 
…-label

Fix not to recreate labels when update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcudit jcudit jcudit approved these changes

Assignees

@jcudit jcudit

Labels
size/S Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renaming labels creates new labels.
3 participants
@shouichi @jcudit @radeksimko