Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GitHub App PEM data to be passed directly #803

Closed
gusnuf opened this issue May 25, 2021 · 2 comments
Closed

Allow GitHub App PEM data to be passed directly #803

gusnuf opened this issue May 25, 2021 · 2 comments
Labels
Provider Type: Feature New feature or request

Comments

@gusnuf
Copy link

gusnuf commented May 25, 2021

The new GitHub app authentication feature launched in 0.4.10 is fantastic (thanks @alloveras), but it forces the application's PEM data to be available to Terraform as a file, the path of which must be passed via the GITHUB_APP_PEM_FILE environment variable. This makes it unusable where the execution environment is not under the user's control, notably Terraform Cloud and Terraform Enterprise.

GITHUB_APP_PEM_FILE is already marked as containing sensitive data, so the simplest option is to allow PEM data to be passed in via this same variable. PEM data is easily detectable as it has ----- as a standard preamble. If this preamble is seen, just use the data directly and don't bother trying to open the file and read its contents.

@jspiro
Copy link
Contributor

jspiro commented May 27, 2021

See #804!

@gusnuf
Copy link
Author

gusnuf commented Jun 14, 2021

Fixed by #804

@gusnuf gusnuf closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Provider Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants