Bump go-github to v37
#893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcudit
approved these changes
Aug 31, 2021
| @@ -331,7 +331,7 @@ func resourceGithubRepositoryFileDelete(d *schema.ResourceData, meta interface{} | |||
| // checkRepositoryBranchExists tests if a branch exists in a repository. | |||
| func checkRepositoryBranchExists(client *github.Client, owner, repo, branch string) error { | |||
| ctx := context.WithValue(context.Background(), ctxId, buildTwoPartID(repo, branch)) | |||
| _, _, err := client.Repositories.GetBranch(ctx, owner, repo, branch) | |||
| _, _, err := client.Repositories.GetBranch(ctx, owner, repo, branch, true) | |||
There was a problem hiding this comment.
Agreed on true as a sane default.
kfcampbell
added a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work on #868, we must be on v38 of the
google/go-githubclient. We're currently 2 major versions behind, so this PR will need to be followed by another one before #868 is unblocked.API Changes include only one breaking change:
Modify GetBranch to handle redirects. I've chosen to default that totruein our code here. Please let me know if that should change!