-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidechain finality missing checks (like InvalidAuthority
)
#58
Comments
We should define, where we keep shared information for pallets and worker such that we do noe need to copy code from one repo to another. |
Check out #50 |
This was referenced Jun 20, 2022
This was referenced Jun 30, 2022
Merged
This was referenced Jul 8, 2022
2 tasks
closed in favor of worker#855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The sidechain finalization pallet will accept and finalize sidechain blocks that are deemed invalid by a validateer.
In the finalization pallet, we check the signature and ancestry. But we don't check if the block was authored in the correct slot. We had a case of this happen regularly on the sidechain: integritee-network/worker#750
So the pallet accepted and finalized a block that was discarded by the validateers. As a result, finalization stops working, because all the subsequent blocks will not have the correct ancestor, and we eventually get the error
We might need to somehow share the logic to determine if a sidechain block is valid, because it is important the finalization pallet and the validateers come to the same conclusion about the validity of a sidechain block.
The text was updated successfully, but these errors were encountered: