Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finalized/tentative state concepts to the state handler #1086

Open
murerfel opened this issue Oct 31, 2022 · 0 comments
Open

Add finalized/tentative state concepts to the state handler #1086

murerfel opened this issue Oct 31, 2022 · 0 comments
Assignees
Labels
A0-core Affects a core part A3-sidechain B1-releasenotes E3-hardmerge PR introduces a lot changes in a lot of files. Requires some effort to merge or rebase to. F8-enhancement New feature or request

Comments

@murerfel
Copy link
Contributor

As part of sidechain finalization, epic #685 and issue #855 and in preparation for #687, we need to introduce the concept of a finalized and a tentative state into our state handler.

The state handler will hold the last finalized state and the tentative state, upon which new sidechain blocks are proposed.
Instead of writing a state snapshot to file for every mutation, we should now change to write only finalized state snapshots. This will be used by #687. In a first step though, we just prepare the implementation and finalize each sidechain block (because we don't have any tracking or acting upon finalization yet).

  • Extend the HandleState trait to differentiate between finalized and tentative state
  • As a result of the above, the handler implementation will then have to state maps
  • Add a new trait for finalizing state. Upon finalization, state is pushed to the snapshot repository
@murerfel murerfel added F8-enhancement New feature or request A0-core Affects a core part A3-sidechain B1-releasenotes E3-hardmerge PR introduces a lot changes in a lot of files. Requires some effort to merge or rebase to. labels Oct 31, 2022
@murerfel murerfel self-assigned this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-core Affects a core part A3-sidechain B1-releasenotes E3-hardmerge PR introduces a lot changes in a lot of files. Requires some effort to merge or rebase to. F8-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant