Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Benchmark: Query state after transaction is InBlock #712

Closed
1 task
masapr opened this issue Apr 13, 2022 · 2 comments
Closed
1 task

Performance Benchmark: Query state after transaction is InBlock #712

masapr opened this issue Apr 13, 2022 · 2 comments
Assignees
@Niederb
Labels
F4-benchmark

Comments

@masapr
Copy link
Contributor

masapr commented Apr 13, 2022

  • To check if state has been correctly updated after the InBlock, send a state query directly after.
@masapr masapr mentioned this issue Apr 13, 2022
Closed
3 tasks
@haerdib haerdib removed their assignment May 13, 2022
@haerdib haerdib assigned Niederb and unassigned masapr May 24, 2022
@Niederb
Copy link
Contributor

Niederb commented Jun 2, 2022

I added a balance check at the very end of the test. Since the money is now transferred in a chain of accounts and the amount decreases on each "hop" I think this is sufficient to guarantee that all updates were executed correctly.

@Niederb
Copy link
Contributor

Niederb commented Jun 7, 2022

This is on the benchmark branch. I would suggest we review the code as part of #175 and close this issue.

@Niederb Niederb closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Niederb Niederb

Labels
F4-benchmark
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Niederb @masapr @haerdib