Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm sidechain blocks when importing instead of when proposing #922

Closed
Tracked by #855
murerfel opened this issue Aug 15, 2022 · 0 comments · Fixed by #949
Closed
Tracked by #855

Confirm sidechain blocks when importing instead of when proposing #922

murerfel opened this issue Aug 15, 2022 · 0 comments · Fixed by #949
Assignees
Labels
F8-enhancement New feature or request

Comments

@murerfel
Copy link
Contributor

Part of #855

As a preparation step for integritee-network/pallets#76, we need to change the workflow of sending sidechain block confirmations to the sidechain pallet.

In its current form, we compose an extrinsic with the confirmation (here, called OpaqueCall) and add it to the list of extrinsics to be sent here.

Now we need to change the workflow: This extrinsic should be composed and sent when IMPORTING the sidechain block.
We ignore the fact that the extrinsic is still called proposed_sidechain_block, which will not be accurate anymore. Re-naming this pallet call will be done in integritee-network/pallets#76.

Sending the block import confirmation can be done on this line.
This will most likely require some refactoring, since the importer then needs a way to compose and send the extrinsic. This may warrant introduction of a new component that composes and sends that extrinsic (and depends on the metadata provider)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F8-enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants