Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support other versions of cyclonedx? #34

Closed
terriko opened this issue Aug 15, 2023 · 3 comments · Fixed by #45
Closed

fix: support other versions of cyclonedx? #34

terriko opened this issue Aug 15, 2023 · 3 comments · Fixed by #45

Comments

@terriko
Copy link
Contributor

terriko commented Aug 15, 2023

I noticed our main repo's SBOMs are now being generated in CycloneDX 1.5:

  "$schema": "http://cyclonedx.org/schema/bom-1.5.schema.json",
  "bomFormat": "CycloneDX",
  "specVersion": "1.5",

But I remembered from code review that we're explicitly looking for CycloneDX 1.3 in a few spots:

if data.find("cyclonedx.org/schema/bom/1.3") != -1:

Do we need to change anything to make sure other versions of CycloneDX get picked up?

@b31ngd3v
Copy link
Contributor

In the cve-bin-tool how to scan sbom doc it says it only supports cyclonedx 1.3.

image

@terriko
Copy link
Contributor Author

terriko commented Aug 21, 2023

Okay, I'll open an issue in the main repo too I guess to see if that's something we need to extend

@terriko
Copy link
Contributor Author

terriko commented Aug 23, 2023

Sounds like the main repo actually supports 1.3-1.5, the docs just need updating. So we should be able to support up to 1.5 here as well.

@b31ngd3v This isn't urgent; your gsoc report & the final documentation tasks should come first. And if you don't feel like getting to this, someone else can work on it later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants