Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI Break introduced in 19.3.4 release tag. #65

Closed
johnbash opened this issue Dec 19, 2019 · 4 comments
Closed

ABI Break introduced in 19.3.4 release tag. #65

johnbash opened this issue Dec 19, 2019 · 4 comments

Comments

@johnbash
Copy link
Contributor

GMMLib is creating revert for ABI break introduced in 19.3.4 release to save package maintenance cost to open source distributions. SO version name will be updated back to libigdgmm.so.11 in future release. Please discard libigdgmm.so.12, no support will continue in future for same.

All existing functionality in libigdgmm.so.11 will be maintained as is.

@jbeich
Copy link

jbeich commented Jan 1, 2020

Note, ABI revert broke API that NEO relied on. See intel/compute-runtime#244 for a fix.

In file included from runtime/kernel/kernel.cpp:10:
core/gmm_helper/gmm_helper.h:42:129: error: use of undeclared identifier 'GmmDestroy'
    static std::unique_ptr<GmmClientContext> (*createGmmContextWrapperFunc)(HardwareInfo *, decltype(&InitializeGmm), decltype(&GmmDestroy));
                                                                                                                                ^
core/gmm_helper/gmm_helper.h:51:15: error: use of undeclared identifier 'GmmDestroy'
    decltype(&GmmDestroy) destroyGmmFunc;
              ^

@JacekDanecki
Copy link

We're preparing fix in Neo repo, it'll be merged soon.

@JacekDanecki
Copy link

With commit Neo switched to gmmlib 19.4.1.

@johnbash
Copy link
Contributor Author

johnbash commented Feb 5, 2020

Fixed the issue in intel-gmmlib-19.4.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants