Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable updateStrategy #1500

Closed
2 tasks
mythi opened this issue Aug 9, 2023 · 2 comments · Fixed by #1786
Closed
2 tasks

enable updateStrategy #1500

mythi opened this issue Aug 9, 2023 · 2 comments · Fixed by #1786
Assignees

Comments

@mythi
Copy link
Contributor

mythi commented Aug 9, 2023

our daemonsets do not have updateStrategy defined/enabled.

  • enable default strategy in plugin daemonSets
  • define user configurable updateStrategy settings and add to the operator (to be decided/defined based on the need)
@hj-johannes-lee hj-johannes-lee self-assigned this Dec 4, 2023
@hj-johannes-lee
Copy link
Contributor

hj-johannes-lee commented Jul 9, 2024

  1. DaemonSet.Spec.UpdateStrategy.Type's default value is RollingUpdate.
    Could you explain what you mean that we need to set a default value? Don't all DaemonSets have default value of updateStrategy as RollingUpdate?

  2. Does your operand use a rolling deployment strategy?
    from https://sdk.operatorframework.io/docs/overview/operator-capabilities/

Doesn't 'rolling deployment strategy' mean RollingUpdate of UpdateStrategy type?

  1. What does the 'bit' have to change? UpdateStrategy.Type can have RollingUpdate or OnDelete. Do you mean about this? Or something else?

@mythi
Copy link
Contributor Author

mythi commented Jul 22, 2024

  1. Could you explain what you mean that we need to set a default value? Don't all DaemonSets have default value of updateStrategy as RollingUpdate?

As far as I understand it, the operator SDK expects the operator to explicitly set the values. Do you read it differently?

3. What does the 'bit' have to change? UpdateStrategy.Type can have RollingUpdate or OnDelete. Do you mean about this? Or something else?

RollingUpdate has parameters that can be configured. They can be useful but perhaps we don't need to add them right now but only focus on making sure we are 'Full lifecycle' compliant. (note: I updated the original description a bit to clarify these)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants