Disable unit test for ARM64/PowerPC architectures #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Some aarch64 and ppc64le implementations of gf_vect_mul do not check for invalid sizes, so the unit test checking for negative return value from this function is disabled temporarily on these architectures. Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
pablodelara
force-pushed
the
pablodelara_disable_test
branch
from
5f546bf to
e3ed308
Compare
|
Closing this PR, as it has been merged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gf_vect_mul() function is expected to check for size alignment to 32 bytes. However, the PowerPC and the SVE aarch64 implementations are not currently checking, so this test is disabled for these architectures until this check is implemented.